Skip to content

feat!: remove deprecated output library fields#12745

Merged
LingyuCoder merged 3 commits intov2from
feat/remove-deprecated-output-fields
Jan 15, 2026
Merged

feat!: remove deprecated output library fields#12745
LingyuCoder merged 3 commits intov2from
feat/remove-deprecated-output-fields

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Jan 15, 2026

Summary

This PR removes deprecated output configuration fields from Rspack and migrates all test cases to use the new API format. The deprecated fields that have been removed include:

  • output.libraryExport - replaced with output.library.export
  • output.libraryTarget - replaced with output.library.type
  • output.umdNamedDefine - replaced with output.library.umdNamedDefine
  • output.auxiliaryComment - replaced with output.library.auxiliaryComment

All test configuration files in tests/rspack-test have been updated to use the new library.type format instead of libraryTarget. The normalization logic has been simplified to only handle the new API format, and all related documentation has been updated accordingly.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from hardfist as a code owner January 15, 2026 07:38
@netlify
Copy link

netlify bot commented Jan 15, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 ready!

Name Link
🔨 Latest commit c8a8790
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/69689c3c6344620008960922
😎 Deploy Preview https://deploy-preview-12745--rspack-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 15, 2026
@LingyuCoder LingyuCoder changed the title feat: remove deprecated output fields and migrate libraryTarget to library.type feat: remove deprecated output library fields Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -8.0 B (-0.0%)
react-1k 825.4 KB 0
react-5k 2.7 MB +1.0 B (0.0%)
rome 986.0 KB +1.7 KB (0.2%)
ui-components 2.1 MB 0
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 0eb2ee3d8b | PR: #12742

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -8.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -8.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 0eb2ee3d8b | PR: #12742

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +1.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +1.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 0eb2ee3d8b | PR: #12742

Metric Current Baseline Change
📊 Total Size 986.0 KB 984.3 KB +1.7 KB (0.2%)
📄 JavaScript 986.0 KB 984.3 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@LingyuCoder LingyuCoder requested a review from fi3ework January 15, 2026 08:04
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

📦 Binary Size-limit

Comparing c8a8790 to refactor: move logger into pass and reorg some passes (#12742) by hardfist

🎉 Size decreased by 471.25KB from 48.03MB to 47.57MB (⬇️0.96%)

@fi3ework
Copy link
Member

fi3ework commented Jan 15, 2026

@codex review

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Comparing feat/remove-deprecated-output-fields (c8a8790) with v2 (b07e854)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Jan 15, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8a87908dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@LingyuCoder LingyuCoder merged commit a0a802b into v2 Jan 15, 2026
55 checks passed
@LingyuCoder LingyuCoder deleted the feat/remove-deprecated-output-fields branch January 15, 2026 08:34
@LingyuCoder LingyuCoder changed the title feat: remove deprecated output library fields feat!: remove deprecated output library fields Jan 16, 2026
@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Jan 16, 2026
@chenjiahan chenjiahan mentioned this pull request Jan 17, 2026
Merged
@jtpio jtpio mentioned this pull request Feb 9, 2026
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@fi3ework fi3ework fi3ework approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LingyuCoder @fi3ework